bpo-30028: os.getpid() is always available#1074
Closed
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:logging_getpid
Closed
bpo-30028: os.getpid() is always available#1074vstinner wants to merge 1 commit intopython:masterfrom vstinner:logging_getpid
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:logging_getpid
Conversation
Remove hasattr(os, 'getpid') from logging.LogRecord constructor. The test was added in 2003 with the commit 4c641d0: "getpid doesn't exist on MacOS9", but Python 3.7 doesn't support MacOS9 anymore.
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vsajip, @benjaminp and @nnorwitz to be potential reviewers. |
Member
Author
|
"test.support uses [os.getpid()] unconditionally in various places. See https://github.com/python/cpython/blob/master/Lib/test/support/__init__.py#L803 for an example." |
Member
Author
|
The current code works well, whereas my change breaks the CloudABI. I prefer to keep the cheap test rather than breaking CloudABI, so I abandon my change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove hasattr(os, 'getpid') from logging.LogRecord constructor. The
test was added in 2003 with the commit 4c641d0: "getpid doesn't
exist on MacOS9", but Python 3.7 doesn't support MacOS9 anymore.