bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol()#7486
Closed
1st1 wants to merge 1 commit intopython:masterfrom
Closed
bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol()#74861st1 wants to merge 1 commit intopython:masterfrom
1st1 wants to merge 1 commit intopython:masterfrom
Conversation
Member
Author
|
@vstinner is working on another PR that doesn't have a problem of reusing a buffer from the old protocol after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Proactor's data receiving code path. The idea is to always use
recv_into()and to emulate the oldProtocol.data_received()path. This waythere is no read cancellation race or data loss in set_protocol() and
there's no performance degradation for both
ProtocolandBufferedProtocol.This PR removes some outdated and now irrelevant proactor mock tests
(most of the removed mocked tests have an alternative working test
for BufferedProtocol).
https://bugs.python.org/issue33694