bpo-33387: update documentation for exception handling opcode changes (GH-24334)

iritkatriel · web-flow · commit dea5bf9d1599 · 2021-01-26T10:17:13.000Z
* bpo-33387: remove obsolete comment * bpo-33387: update SETUP_WITH opcode documentation
diff --git a/Doc/library/dis.rst b/Doc/library/dis.rst
@@ -742,7 +742,7 @@ iterations of the loop.
 
    This opcode performs several operations before a with block starts.  First,
    it loads :meth:`~object.__exit__` from the context manager and pushes it onto
-   the stack for later use by :opcode:`WITH_CLEANUP_START`.  Then,
+   the stack for later use by :opcode:`WITH_EXCEPT_START`.  Then,
    :meth:`~object.__enter__` is called, and a finally block pointing to *delta*
    is pushed.  Finally, the result of calling the ``__enter__()`` method is pushed onto
    the stack.  The next opcode will either ignore it (:opcode:`POP_TOP`), or
diff --git a/Python/compile.c b/Python/compile.c
@@ -898,8 +898,6 @@ compiler_next_instr(basicblock *b)
    * 1 -- when jump
    * -1 -- maximal
  */
-/* XXX Make the stack effect of WITH_CLEANUP_START and
-   WITH_CLEANUP_FINISH deterministic. */
 static int
 stack_effect(int opcode, int oparg, int jump)
 {

Original file line number	Diff line number	Diff line change
`@@ -898,8 +898,6 @@ compiler_next_instr(basicblock *b)`
`898`	`898`	`* 1 -- when jump`
`899`	`899`	`* -1 -- maximal`
`900`	`900`	`*/`
`901`		`-/* XXX Make the stack effect of WITH_CLEANUP_START and`
`902`		`- WITH_CLEANUP_FINISH deterministic. */`
`903`	`901`	`static int`
`904`	`902`	`stack_effect(int opcode, int oparg, int jump)`
`905`	`903`	`{`