Repository navigation
Add support to read name of Pipfile from environment variable #999
Description
Name of the Pipfile is currently hardcoded in the extension.
This could come from an environment variable (see here https://github.com/pypa/pipenv/blob/5f48233637adc99bb16e6c601a728dc641bd5cd2/pipenv/environments.py#L29)
TODO: Confirm this is the case and create necessary PR accordingly.
Activity
brettcannon commentedon Mar 9, 2018
In this instance we may need to just use
pipenv --venvor some such command to do the detection appropriately.MikhailArkhipov commentedon Mar 9, 2018
Yes, running command is a better test, but watch out for performance. This was the reason for the file check. Interpreter selection and startup time.
DonJayamanne commentedon Mar 13, 2018
Brett Cannon (@brettcannon) Mikhail Arkhipov (@MikhailArkhipov)
Not sure what you two are referring to here. Running any pipenv command will not tell us the name of the
Pipfile. The name of the Pip file can be provided in the environment variable:All we need to do is:
Pipfile(current behavior)brettcannon commentedon Mar 13, 2018
What I'm saying is we simply don't care about a
Pipfileand instead just care if pipenv knows of a virtual environment for the directory.Add support to read name of Pipfile from environment variable (#1092)