Repository navigation
Conversation
Expat calls the default handler once per 1024-byte piece of a token that needs encoding conversion. Install a no-op instead of NULL when the handler is cleared after an error or unset from within a callback, as is already done for the character data handler.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expat calls the default handler once per 1024-byte piece of a token that needs encoding conversion and re-reads the handler pointer between pieces, so pyexpat must not set it to NULL from inside a callback. When handlers are cleared after an error, or
DefaultHandler/DefaultHandlerExpandis set toNonefrom inside a callback, install the existing no-op handler instead, as has been done for the character data handler since gh-42389. The Python-level handlers are still cleared, so no Python code runs after an error, and the handler setters are called in the same order, so the internal-entity expansion setting ends up as before.Fixes #161060
ANT-2026-0SJB3WWC
xml.parsers.expatcrashes whenDefaultHandlerraises on a long non-UTF-8 token #161060