fix: Always draw full arcs and borders for doughnut slices #10806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Oct 18, 2022
etimberg
approved these changes
Oct 18, 2022
LeeLenaleee
approved these changes
Oct 19, 2022
kurkle
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10801
The root cause was bad behavior when floating-point arithmetic just pushed a single slice into self-overlap territory and
drawFullCircleBordersdoes not account for offset likepathArcdoes, resulting in borders drawn in the wrong location. This PR updatesdrawBorderto rely onpathArcinstead, although I suspect further improvements could fully unify everything and draw arcs and borders together.