chore: use 2 different exporter instances for internal and external metrics #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrics This is necessary to unblock upcoming changes that will track additional metrics and a new unified BigtableClient monitored resource. Change-Id: I3a051f1faccaba1fc17e4151d1ed85ff8e5952f6
product-auto-label
bot
added
size: l
Change-Id: I3f3765ed816922ecf30f28ce66c2271158d9f6bf
Change-Id: I9e4cda1ade196cc4f22191f6284e0ec85642b482
Change-Id: I16d2fb78e10e0a6b8ce8f89617269ed42e0a3c9f
...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java
Outdated
Show resolved
Hide resolved
...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java
Outdated
Show resolved
Hide resolved
Change-Id: I07a36299cb0004dae4601a8fbb8d37ee93486b8f
andre-sampaio
approved these changes
Mar 13, 2025
Change-Id: Iccb5ceeb0d4eaf7aba9283642e4be15ae8d43596
Change-Id: I9fa2b8fa840eae9bf434e72510f04a77b2166c74
Change-Id: I98ad5c58e33f35f6165db39963467b17cf7d8745
igorbernstein2
changed the title
igorbernstein2
added a commit
that referenced
this pull request
Mar 13, 2025
Building on #2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource Changes: - create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters) - create internal metrics as part of BigtableClientContext creation - split off internal views Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe
6 tasks
andre-sampaio
pushed a commit
that referenced
this pull request
Mar 19, 2025
…etrics (#2515) * chore: use 2 different exporter instances for internal and external metrics This is necessary to unblock upcoming changes that will track additional metrics and a new unified BigtableClient monitored resource. Change-Id: I3a051f1faccaba1fc17e4151d1ed85ff8e5952f6 * skip export if the application resource is unsupported Change-Id: I3f3765ed816922ecf30f28ce66c2271158d9f6bf * tweaks Change-Id: Ia3f7698fb9e17c015e6d99e8599d31dd93b5efe5 * ensure that exporters use the same task id Change-Id: I9e4cda1ade196cc4f22191f6284e0ec85642b482 * chore: generate libraries at Thu Mar 13 02:31:04 UTC 2025 * tweaks Change-Id: I145e75f3e7628decd844e61c36936cabbac7f3eb * clean up tests Change-Id: I16d2fb78e10e0a6b8ce8f89617269ed42e0a3c9f * fix clirr Change-Id: Ie971e3a06da180639d9d36d4941bbb1fd6bcebf8 * fix clirr Change-Id: I23352ecfaf13a95fa2cfed165b0dba8ec4c47cfc * address fedback Change-Id: I07a36299cb0004dae4601a8fbb8d37ee93486b8f * deflake unrelated test again Change-Id: I9fa2b8fa840eae9bf434e72510f04a77b2166c74 * try to deflake test Change-Id: I98ad5c58e33f35f6165db39963467b17cf7d8745 --------- Co-authored-by: cloud-java-bot <[email protected]>
igorbernstein2
added a commit
that referenced
this pull request
Mar 19, 2025
Building on #2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource Changes: - create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters) - create internal metrics as part of BigtableClientContext creation - split off internal views Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe
igorbernstein2
added a commit
that referenced
this pull request
Mar 25, 2025
* chore: create a separate otel instance for internal metrics Building on #2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource Changes: - create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters) - create internal metrics as part of BigtableClientContext creation - split off internal views Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe * fix typo Change-Id: Ia28cb95408ecf7e8ab785c5f54c0149388df202a * try to deflake the metrics test again Change-Id: I9f99e1a0f75f1337d09ba3833fe7833e03818519 * improve comment Change-Id: I3376b36bf41c9395b4fcd62c7905312dd2c3a6c9
andre-sampaio
pushed a commit
to andre-sampaio/java-bigtable
that referenced
this pull request
Apr 24, 2025
…is#2522) * chore: create a separate otel instance for internal metrics Building on googleapis#2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource Changes: - create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters) - create internal metrics as part of BigtableClientContext creation - split off internal views Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe * fix typo Change-Id: Ia28cb95408ecf7e8ab785c5f54c0149388df202a * try to deflake the metrics test again Change-Id: I9f99e1a0f75f1337d09ba3833fe7833e03818519 * improve comment Change-Id: I3376b36bf41c9395b4fcd62c7905312dd2c3a6c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to unblock upcoming changes that will track additional metrics and a new unified BigtableClient monitored resource.
The primary change was to extract metric data creation from BigtableCloudMonitoringExporter into TimeSeriesConverter. This removes the code duplication in exportBigtableResourceMetrics & exportApplicationResourceMetrics. But more importantly it allows us to have to 2 separate instances of BigtableCloudMonitoringExporter - one for internal metrics and another for public metrics. This will be needed in follow up PRs that will change the monitored resource that internal metrics use - the new monitored resource is incompatible CustomOpenTelemetryMetricsProvider that is needed for public metrics
Change-Id: I3a051f1faccaba1fc17e4151d1ed85ff8e5952f6
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.