-
Notifications
You must be signed in to change notification settings - Fork 320
feat: adds time_zone to external config and load job #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
07c66aa
e02e24b
ff0645a
5e6e619
ee7e7de
c584a5a
10f7cd4
dd6f7ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to https://github.com/googleapis/python-bigquery/pull/2229/files#r2191183829, I think in general we need to test against to/from_api_repr and the property itself. The same goes for
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pattern/philosophy for Here, the author chose to test each attribute in more of a stand alone fashion using a trifecta of tests:
But: Examples:
missingConfirms that when the target class is created, the attribute is not populated hitSets (behind the scenes using setterSets the value of the attribute directly using the setter function
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a |
Uh oh!
There was an error while loading. Please reload this page.