Skip to content

Conversation

@jhalliday
Copy link
Contributor

No description provided.

@jhalliday jhalliday requested a review from a team as a code owner April 25, 2025 12:26
@jhalliday
Copy link
Contributor Author

Nothing much exciting in the code here, it's mostly to a pattern copied from other signal types. The code packaging differs a little, since the profiles signal is still in development and doesn't yet have a separate user API. This makes the dependencies for both the profiles module and the exporters testing-internal module a bit messier than I'd like, but it should get straightened out when things move out of development phase. Could perhaps be 'improved' at the cost of duplicating more of the test harness, but I'm not convinced that would count as a win.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (394cd35) to head (c35eb5f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...metry/exporter/internal/grpc/GrpcExporterUtil.java 0.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7301      +/-   ##
============================================
- Coverage     89.88%   89.86%   -0.03%     
+ Complexity     6898     6897       -1     
============================================
  Files           786      786              
  Lines         20789    20792       +3     
  Branches       2025     2026       +1     
============================================
- Hits          18686    18684       -2     
- Misses         1463     1466       +3     
- Partials        640      642       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of minor comments. Thanks!

@jhalliday
Copy link
Contributor Author

@jack-berg thanks for the review. Fixed most of them, just the env var to make a decision on. Also, slightly concerned the codecov bot and I don't agree on what the test coverage actually is - known issues with it, or tests not getting executed?

@jhalliday
Copy link
Contributor Author

@jack-berg ready for another review now I think, thanks. No idea why apiCmp suddenly decided to sulk though.

@jack-berg
Copy link
Member

@jack-berg ready for another review now I think, thanks. No idea why apiCmp suddenly decided to sulk though.

Its an artifact of a small issue with the 1.50.0 release. See #7344 for details. After that is merged, we can merge main and should be good.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit bed02d5 into open-telemetry:main May 13, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants