-
Notifications
You must be signed in to change notification settings - Fork 920
Add gRPC export for profiles signal type. #7301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nothing much exciting in the code here, it's mostly to a pattern copied from other signal types. The code packaging differs a little, since the profiles signal is still in development and doesn't yet have a separate user API. This makes the dependencies for both the profiles module and the exporters testing-internal module a bit messier than I'd like, but it should get straightened out when things move out of development phase. Could perhaps be 'improved' at the cost of duplicating more of the test harness, but I'm not convinced that would count as a win. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7301 +/- ##
============================================
- Coverage 89.88% 89.86% -0.03%
+ Complexity 6898 6897 -1
============================================
Files 786 786
Lines 20789 20792 +3
Branches 2025 2026 +1
============================================
- Hits 18686 18684 -2
- Misses 1463 1466 +3
- Partials 640 642 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a handful of minor comments. Thanks!
exporters/common/src/main/java/io/opentelemetry/exporter/internal/grpc/GrpcExporterUtil.java
Outdated
Show resolved
Hide resolved
...lp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/MultiProfilesExporter.java
Outdated
Show resolved
Hide resolved
...rs/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/ProfilesExporter.java
Outdated
Show resolved
Hide resolved
...rs/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/ProfilesExporter.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/io/opentelemetry/exporter/otlp/profiles/OtlpGrpcProfilesExporterBuilder.java
Show resolved
Hide resolved
...s/otlp/profiles/src/test/java/io/opentelemetry/exporter/otlp/profiles/FakeTelemetryUtil.java
Outdated
Show resolved
Hide resolved
...iles/src/test/java/io/opentelemetry/exporter/otlp/profiles/OtlpGrpcProfilesExporterTest.java
Outdated
Show resolved
Hide resolved
|
@jack-berg thanks for the review. Fixed most of them, just the env var to make a decision on. Also, slightly concerned the codecov bot and I don't agree on what the test coverage actually is - known issues with it, or tests not getting executed? |
Changes per code review feedback
Changes per code review feedback
|
@jack-berg ready for another review now I think, thanks. No idea why apiCmp suddenly decided to sulk though. |
Its an artifact of a small issue with the 1.50.0 release. See #7344 for details. After that is merged, we can merge main and should be good. |
jack-berg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…y-java into jh-profiling-j
No description provided.