fixes #7427: Patch LazyStorage to pass its ClassLoader to ServiceLoader

[indigophox]

LazyStorage passes its ContextStorageProvider.class to ServiceLoader.load(). However, this is done from the LazyStorage static initializer, so the application has little to no control over the execution thread context for this code, and by default ServiceLoader uses the Thread context classloader, which may or may not have a different instance of ContextStorageProvider and its desendants.

This patch passes the classloader from LazyStorage to ServiceLoader so that it is able to find true (rather than just symbolic) descendants of that same class. Otherwise, if OpenTelemetry is loaded in a multi-classloader application, it can easily end up throwing a ServiceConfigurationError because ServiceLoader sees a different set of class instances than the set which the passed-in ContextStorageProvider.class is from.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: indigophox / name: Paul Nienaber (3ea9ba5)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (cc2844d) to head (3ea9ba5).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7424   +/-   ##
=========================================
  Coverage     89.75%   89.75%           
  Complexity     6980     6980           
=========================================
  Files           797      797           
  Lines         21165    21165           
  Branches       2057     2057           
=========================================
  Hits          18996    18996           
  Misses         1505     1505           
  Partials        664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[anuraaga]

Code looks good thanks!

[jkwatson]

@indigophox we need your commits to be associated with a github account which has signed the CNCF CLA.

[indigophox]

@jkwatson got it, I will rattle the grapevine here tomorrow. Thank you!

[indigophox]

Ok CLA stuff appears to be sorted.

[indigophox]

Thank you! Is it possible to get this into a point or minor release soon-ish? This bug is blocking a release for us.

[jkwatson]

We wouldn't normally do a special release for this kind of change, but just fold it into the next release, as we generally only issue mid-cycle patches for security issues or new bugs that were introduced. Exceptions can be made, but they would need to be exceptional.

The next release should be the 2nd week of July, I believe.

[indigophox]

Sounds like we are good to wait on our end. Thanks again!

[jack-berg]

Thanks!

[indigophox]

Thank -you-! We're the ones blocked on this and appreciate it moving ahead!