[config] restore backfill enable flag - #2
Closed
90-008 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review AGENTS.md#for-humans. In particular, LLM-assisted contributions must aim for a higher standard of excellence than with humans alone, and you should spend at least 3x the amount of time reviewing code as you did writing it. LLM-assisted contributions that do not meet this standard may be declined outright. Remember, your code is your responsibility.
Motivation
Description
enable_backfill: boolonConfigand include it inDisplayoutput (src/config.rs).HYDRANT_ENABLE_BACKFILLin the environment loader and carry the value intoConfig::from_env()(src/config/env.rs).backfill_enabledwatch channel fromconfig.enable_backfillinstead of unconditionally enabling it (src/state.rs).enable_backfilltotrueinConfig::default()so existing deployments are unaffected unless they explicitly opt out.Testing
cargo check --lockedwith a workaround (temporarily moved aside the repository.cargo/config.tomlthat injects a custom linker flag) and the build finished successfully; this verifies the changes compile in a standard toolchain environment.cargo check --lockedfailure due to the local.cargo/config.tomlpassing an unsupported--ld-path=wildlinker argument in this environment, which is unrelated to the changes and was worked around as described above.git diff --checkpassed and changes were committed as[config] restore backfill enable flag.Codex Task