Skip to content

http: use objects with null prototype in Agent - #36409

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-36364
Closed

http: use objects with null prototype in Agent#36409
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-36364

Conversation

@targos

@targos targos commented Dec 6, 2020

Copy link
Copy Markdown
Member

Fixes: #36364

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues and PRs related to the http subsystem. label Dec 6, 2020
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Dec 6, 2020
@targos

targos commented Dec 6, 2020

Copy link
Copy Markdown
Member Author

I suppose this should be semver-major?

@targos
targos force-pushed the fix-36364 branch 2 times, most recently from 293eb85 to bd8d4f9 Compare December 6, 2020 14:18
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@nodejs-github-bot

ghost commented Dec 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34792/

@targos targos mentioned this pull request Dec 6, 2020
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@nodejs-github-bot

ghost commented Dec 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34831/

@targos targos mentioned this pull request Dec 9, 2020
Closed
@targos

ghost commented Dec 9, 2020

Copy link
Copy Markdown
Member Author

@nodejs/tsc @nodejs/http

mcollina
mcollina approved these changes Dec 9, 2020
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2020
@nodejs-github-bot

ghost commented Dec 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34907/

@nodejs-github-bot

ghost commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34918/

@nodejs-github-bot

ghost commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34928/

@targos

ghost commented Dec 13, 2020

Copy link
Copy Markdown
Member Author

Landed in 2ef9a76

@targos targos closed this Dec 13, 2020
@targos
targos deleted the fix-36364 branch December 13, 2020 21:16
@BethGriggs BethGriggs mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@Trott Trott Trott approved these changes
@Flarna Flarna Flarna approved these changes

Assignees

No one assigned

Labels

http Issues and PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot make a node-fetch request, TypeError: Cannot read property 'Symbol(requestOptions)' of undefined

5 participants

@targos @nodejs-github-bot @mcollina @Trott @Flarna