[6.x] Tidy up login credential handling - #15335
Merged
Merged
Conversation
The check now runs against the already-validated user, before the two-factor branch. A login with the wrong password gets the generic failure rather than the passkey message, and the password is verified first — so it can be rehashed on a login that's then refused, and the attempt counts against the wrong-password throttle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes to
HandlesLoginsand the two login controllers:Timebox, so a login attempt takes a consistent amount of time regardless of which branch it takes. This is the same thing Laravel's guard does aroundattempt(), which these controllers don't go through.Covers both the Control Panel and frontend user login.