Skip to content

Fix a few PR links in the changelog - #18586

Merged
hauntsaninja merged 1 commit into
python:masterfrom
hamdanal:fix-changelog
Feb 2, 2025
Merged

Fix a few PR links in the changelog#18586
hauntsaninja merged 1 commit into
python:masterfrom
hamdanal:fix-changelog

Conversation

@hamdanal

@hamdanal hamdanal commented Feb 2, 2025

Copy link
Copy Markdown
Collaborator

And add a local pre-commit hook to detect when a PR number in a link text is different from the link body

And add a local pre-commit hook to detect when a PR number in
a link text is different from the link body
Comment thread CHANGELOG.md
Use this flag to disable this behavior. `--strict-bytes` will be enabled by default in **mypy 2.0**.

Contributed by Ali Hamdan (PR [18137](https://github.com/python/mypy/pull/18263/)) and
Contributed by Ali Hamdan (PR [18263](https://github.com/python/mypy/pull/18263)) and

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detected with the pre-commit hook

@github-actions

github-actions Bot commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hauntsaninja
hauntsaninja merged commit 1f509ec into python:master Feb 2, 2025
@hamdanal
hamdanal deleted the fix-changelog branch February 3, 2025 07:02
wesleywright pushed a commit that referenced this pull request Feb 5, 2025
And add a local pre-commit hook to detect when a PR number in a link
text is different from the link body
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
And add a local pre-commit hook to detect when a PR number in a link
text is different from the link body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants