This repository was archived by the owner on Aug 30, 2026. It is now read-only.
fix: Fix the race condition in decay average - #850
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
google-cla
Bot
added
the
cla: yes
igorbernstein2
suggested changes
Jun 2, 2021
| // Set last update time so when we're getting the mean we can calculate the decay based on the | ||
| // last time the mean was updated. | ||
| if (now > lastUpdateTimeInSecond.get()) { | ||
| lastUpdateTimeInSecond.set(now); |
Contributor
There was a problem hiding this comment.
why is this still necessary? isnt this done in updateStartTime now?
Contributor
Author
There was a problem hiding this comment.
Hmm, so if getMean is called after like 5 minutes of update (before we need to update start time) the average will be decayed?
igorbernstein2
suggested changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️