bpo-43770: Inherit default tp_getattro and tp_setattro #25275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
1st1,
ethanfurman,
markshannon,
methane and
rhettinger
as code owners
Member
Author
|
It doesn't work as expected: https://bugs.python.org/issue43770#msg390519 |
Don't set tp_getattro and tp_setattro explicitly to PyObject_GenericGetAttr() and PyObject_GenericSetAttr(): they are the default.
rhettinger
previously approved these changes
Apr 20, 2021
rhettinger
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 31f39ae 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
@rhettinger: this PR is supposed to have no effect, but PyType_Ready() doesn't work as expected :-( I'm still investigating why this PR has a side effect and trying to understand if it's a bug or a feature :-) |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
|
This change looked like a good idea, but it caused way more problems that what I expected. I prefer to stop the work on https://bugs.python.org/issue43770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't set tp_getattro and tp_setattro explicitly to
PyObject_GenericGetAttr() and PyObject_GenericSetAttr(): they are the
default.
https://bugs.python.org/issue43770