fixes possible chmod bug - #337
Merged
Merged
Conversation
The implementation of chmod was calculating the new permissions, but then setting the permissions back to the old ones. This fixes this bug. Similarly, the value returned was the od value rather than the new one.
Owner
|
No apology necessary! Thank you for fixing this bug 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for such a low value PR, and if I have misunderstood the intentions of any of the functions.
I was trying to use the chmod function recently and noticed that it was failing to change the permissions of any paths.
This seems to be because it is calculating the new permissions and then writing back the old ones. This changes it to write back the new ones, which gives it behaviour closer to what I'd expect from reading the documentation.