Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Particular/ServiceControl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.14.2
Choose a base ref
...
head repository: Particular/ServiceControl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.14.3
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on May 19, 2026

  1. 🐛 Add failing test: SortInfoModelBinder drops time_of_failure/modified 

    The Primary instance global SortInfoModelBinder allowlist is missing the
'time_of_failure' and 'modified' sort keys. When ServicePulse requests the
failed-message list sorted by Time of failure (sort=time_of_failure), the
binder silently rewrites the token to 'time_sent', so the RavenDB layer —
which does support TimeOfFailure ordering — never sees it. The list ends up
ordered by Time sent regardless of the user's choice.

This test reproduces the defect at the binder level (RED).
    @ramonsmits
    ramonsmits committed May 19, 2026
    Configuration menu
    Copy the full SHA
    d13d9e6 View commit details
    Browse the repository at this point in the history

  2. 🐛 Allow time_of_failure/modified sort for failed messages 

    Add the two missing sort keys to the Primary instance SortInfoModelBinder
allowlist so that sort=time_of_failure (and sort=modified) survive model
binding and reach the RavenDB query, which already maps them to the
TimeOfFailure / LastModified index fields.

Fixes the ServicePulse failed-message list ordering by 'Time of failure',
which previously fell back to 'Time sent'. (GREEN)
    @ramonsmits
    ramonsmits committed May 19, 2026
    Configuration menu
    Copy the full SHA
    adb1581 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5479 from Particular/fix/failed-messages-sort-by-… 

    …time-of-failure-6.14

Failed-message list cannot be sorted by "Time of failure" — silently falls back to "Time sent"
    @ramonsmits
    ramonsmits authored May 19, 2026
    Configuration menu
    Copy the full SHA
    e8e33d8 View commit details
    Browse the repository at this point in the history
Loading