Fixed - Filter Guidelines service queries by wp_guideline_type=content - #531
Closed
itsgajendraSingh wants to merge 1 commit into
Closed
Conversation
When the wp_guideline_type taxonomy is registered (Gutenberg 23.1+), a newer artifact guideline could be selected instead of the intended content guideline during prompt assembly. Add a tax_query to restrict fetched posts to the 'content' term when the taxonomy exists. Fixes WordPress#529
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gajendraSingh26. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GUIDELINE_TYPE_TAXONOMYconstant (wp_guideline_type) and a privateGUIDELINE_TYPE_CONTENTconstant (content) to theGuidelinesservice.wp_guideline_typetaxonomy is registered (Gutenberg 23.1+),fetch_guidelines()now appends atax_queryto restrict the query to posts assigned thecontentterm, preventing a newerartifactguideline from shadowing the intended content guideline during prompt assembly.Fixes #529.
Changes
includes/Services/Guidelines.php— add constants, conditionally addtax_queryinfetch_guidelines().tests/Integration/Includes/Services/Guidelines_CPT_Helpers.php— addregister_guideline_type_taxonomy()helper; extendcreate_guidelines_post()with an optional$guideline_typeparameter.tests/Integration/Includes/Services/Guidelines_Test.php— add two new tests covering the mixed artifact/content scenario and the untyped-post edge case.Test plan
Guidelines_Testsuite still passes.test_get_guidelines_ignores_artifact_type_when_taxonomy_existsconfirms the content guideline is returned when a newer artifact guideline also exists.test_get_guidelines_returns_null_for_untyped_post_when_taxonomy_existsconfirms untyped posts are excluded when the taxonomy is present.