Update documentation around the encryption experiment and address a few bugs - #909
Update documentation around the encryption experiment and address a few bugs#909dkotter wants to merge 4 commits into
Conversation
…does and does not do, namely that it does not prevent other plugins from accessing the encrypted data
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #909 +/- ##
=============================================
+ Coverage 80.43% 80.57% +0.14%
- Complexity 2565 2568 +3
=============================================
Files 110 110
Lines 10448 10453 +5
=============================================
+ Hits 8404 8423 +19
+ Misses 2044 2030 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What?
Update our documentation to make it more clear what the encryption experiment does and does not do. Make a few refinements / bug fixes along the way.
Why?
We've had some reports that seem to misunderstand the encryption experiment, most importantly they seem to think that encrypted data is locked down to the AI plugin only and shouldn't be accessible by other plugins. This is not how that experiment was built and honestly not sure there's a way to achieve this within WordPress, since WordPress allows plugins to do basically anything.
This PR updates the documentation around this experiment to make it more clear about what it is doing and things it won't help with, like preventing other plugins from accessing API keys.
In addition, a few modifications/fixes have been done based on these reports, namely ensuring we better detect the calling plugin instead of always attributing everything to the AI plugin and passing the calling plugin into our logging methods.
How?
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Reviewing some reports and helping verify what actually needs fixing. Once a plan was settled on, it executed the plan with final review and testing by me
Testing Instructions
Ensure the encryption experiment still works as expected. Easiest to follow instructions in the original PR, #560
Changelog Entry