Skip to content

Build Tools: Remove deprecated esModuleInterop: false from tsconfig - #77009

Closed
manzoorwanijk wants to merge 1 commit into
trunkfrom
remove/deprecated-esmoduleinterop
Closed

Build Tools: Remove deprecated esModuleInterop: false from tsconfig#77009
manzoorwanijk wants to merge 1 commit into
trunkfrom
remove/deprecated-esmoduleinterop

Conversation

@manzoorwanijk

@manzoorwanijk manzoorwanijk commented Apr 2, 2026

Copy link
Copy Markdown
Member

What?

Remove the deprecated esModuleInterop: false setting from tsconfig.base.json.

Why?

The esModuleInterop=false option is deprecated in TypeScript 6.0 and will stop functioning in TypeScript 7.0, producing a warning in the IDE. Removing it now eliminates the warning while keeping the same default behavior (false). allowSyntheticDefaultImports: true already handles default imports for type-checking.

How?

Removed the esModuleInterop: false line and its associated comment from tsconfig.base.json.

Testing Instructions

  1. Run npm run build — should complete successfully.
  2. Open any package's tsconfig.json in an IDE — the deprecation warning should be gone.

Testing Instructions for Keyboard

N/A — no UI changes.

Use of AI Tools

This PR was authored with the assistance of Claude Code (claude-opus-4-6).

@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@manzoorwanijk manzoorwanijk self-assigned this Apr 2, 2026
The `esModuleInterop=false` option is deprecated in TypeScript 6.0 and
will stop functioning in TypeScript 7.0. Removing it now keeps the same
default behavior while eliminating the deprecation warning.
`allowSyntheticDefaultImports: true` already handles default imports for
type-checking.
@manzoorwanijk
manzoorwanijk force-pushed the remove/deprecated-esmoduleinterop branch from 85070bc to 03f3a94 Compare April 2, 2026 17:31
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

Flaky tests detected in 03f3a94.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23913399924
📝 Reported issues:

@manzoorwanijk

Copy link
Copy Markdown
Member Author

Closing in favor of #77010

@manzoorwanijk
manzoorwanijk deleted the remove/deprecated-esmoduleinterop branch April 2, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant