Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Automatic Layout Management - #20718

Merged
ptrendx merged 11 commits into
apache:masterfrom
mk-61:pr-auto-layout-only
Dec 2, 2021
Merged

Automatic Layout Management#20718
ptrendx merged 11 commits into
apache:masterfrom
mk-61:pr-auto-layout-only

Conversation

@mk-61

@mk-61 mk-61 commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

Automatic Layout Management improves performance when used together with AMP by converting parts of the computational graph to NHWC layouts.

Description

Target graph parts (containing convolution / deconvolution ops) are automatically converted to NHWC layout by surrounding with transposes.
This functionality was originally implemented by Dawid Tracz dtracz@nvidia.com in the Nvidia container. I later changed the algorithm to a single pass of DFSVisit.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)

Changes

  • A new layout_optimization flag is added to amp.init() call

Comments

This other PR: #20635 is required in order to get the expected performance improvements.

@mxnet-bot

mxnet-bot commented Nov 1, 2021

Copy link
Copy Markdown

Hey @mk-61 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-gpu, windows-cpu, sanity, unix-gpu, centos-gpu, website, clang, centos-cpu, unix-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 1, 2021
@mk-61

mk-61 commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [macosx-x86_64, centos-gpu, unix-gpu, website, windows-gpu]

@mxnet-bot

mxnet-bot commented Nov 2, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [centos-gpu, unix-gpu, windows-gpu, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 2, 2021
ptrendx
ptrendx reviewed Nov 11, 2021
View reviewed changes
Comment thread src/c_api/c_api.cc Outdated
ptrendx
ptrendx reviewed Nov 11, 2021
View reviewed changes
Comment thread src/common/alm.cc Outdated
@mk-61
mk-61 force-pushed the pr-auto-layout-only branch from 5a54053 to 0ddf20a Compare November 16, 2021 04:14
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 16, 2021
@mk-61

mk-61 commented Nov 16, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot

mxnet-bot commented Nov 16, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Nov 16, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 30, 2021
@mk-61

mk-61 commented Nov 30, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot

mxnet-bot commented Nov 30, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 30, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 30, 2021
@mk-61

mk-61 commented Nov 30, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [sanity]

@mxnet-bot

mxnet-bot commented Nov 30, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [sanity]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 30, 2021
@mk-61

mk-61 commented Nov 30, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [centos-cpu, centos-gpu, unix-cpu, unix-gpu, windows-cpu, windows-gpu]

@mxnet-bot

mxnet-bot commented Nov 30, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [centos-cpu, windows-cpu, unix-cpu, windows-gpu, centos-gpu, unix-gpu]

@mk-61

mk-61 commented Nov 30, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [clang, edge, miscellaneous, website]

@mxnet-bot

mxnet-bot commented Nov 30, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [edge, clang, miscellaneous, website]

@mk-61

mk-61 commented Dec 1, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [centos-cpu]

@mxnet-bot

mxnet-bot commented Dec 1, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [centos-cpu]

@mk-61

mk-61 commented Dec 1, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot

mxnet-bot commented Dec 1, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu]

@mk-61

mk-61 commented Dec 1, 2021

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot

mxnet-bot commented Dec 1, 2021

Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu]

ptrendx
ptrendx approved these changes Dec 2, 2021
View reviewed changes

@ptrendx ptrendx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments :-).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner
@szha szha Awaiting requested review from szha szha is a code owner
1 more reviewer
@ptrendx ptrendx ptrendx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mk-61 @mxnet-bot @ptrendx @mseth10 @vcherepanov-nv