lib,src: use built-in array buffer detach - #50130
Closed
anonrig wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
added
c++
anonrig
force-pushed
the
array-buffer-transfer
branch
4 times, most recently
from
October 10, 2023 21:13
63d7adb to
8eaae52
Compare
anonrig
added
commit-queue-rebase
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Member
|
Note that the v8 flag |
ljharb
requested changes
Oct 11, 2023
Member
There was a problem hiding this comment.
this is a mutable property, so it must be a primordial
Suggested change
| if (viewBuffer.detached) { | |
| if (ArrayBufferPrototypeDetached(viewBuffer)) { |
Member
There was a problem hiding this comment.
Suggested change
| if (ArrayBufferViewGetBuffer(view).detached) { | |
| if (ArrayBufferPrototypeDetached(ArrayBufferViewGetBuffer(view)) { |
Member
There was a problem hiding this comment.
Suggested change
| const transferredBuffer = buffer.transfer(); | |
| const transferredBuffer = ArrayBufferPrototypeTransfer(buffer); |
Member
There was a problem hiding this comment.
Suggested change
| transferredBuffer = buffer.transfer(); | |
| transferredBuffer = ArrayBufferPrototypeTransfer(buffer); |
Member
There was a problem hiding this comment.
Suggested change
| desc.buffer = desc.buffer.transfer(); | |
| desc.buffer = ArrayBufferPrototypeTransfer(desc.buffer); |
Member
There was a problem hiding this comment.
Suggested change
| const transferredBuffer = buffer.transfer(); | |
| const transferredBuffer = ArrayBufferPrototypeTransfer(buffer); |
Member
There was a problem hiding this comment.
Suggested change
| if (firstPendingPullInto.buffer.detached) { | |
| if (ArrayBufferPrototypeDetached(firstPendingPullInto.buffer)) { |
Member
There was a problem hiding this comment.
Suggested change
| firstPendingPullInto.buffer = firstPendingPullInto.buffer.transfer(); | |
| firstPendingPullInto.buffer = ArrayBufferPrototypeTransfer(firstPendingPullInto.buffer); |
Member
There was a problem hiding this comment.
Suggested change
| desc.buffer = viewBuffer.transfer(); | |
| desc.buffer = ArrayBufferPrototypeTransfer(viewBuffer); |
anonrig
force-pushed
the
array-buffer-transfer
branch
from
October 12, 2023 15:02
8eaae52 to
9096c77
Compare
Member
Author
|
@legendecas would you be interested in removing the flag that disables arraybuffer.prototype.detach, from v8? |
Member
|
Sure, the feature has been released since M111 and I believe it is a good time to remove the flag. |
Member
|
v8/v8@9ebca66 the flag was removed since V8 12.6. |
Member
Author
I couldn't make the |
Member
|
My |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change requires v8 11.8, therefore can't be backported to v18 and v20