http2: fix async context loss when trailers carry END_STREAM - #63814
Open
orgads wants to merge 1 commit into
Open
http2: fix async context loss when trailers carry END_STREAM#63814orgads wants to merge 1 commit into
orgads wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
orgads
force-pushed
the
http2-async-trailers
branch
from
June 9, 2026 10:20
00f4171 to
a39d251
Compare
Qard
approved these changes
Jun 9, 2026
Contributor
Author
|
The macOS failure looks unrelated to my change. |
github-actions
Bot
removed
the
request-ci
Collaborator
The previous fix (f67e45e) wrapped header/response event dispatch in reqAsync.runInAsyncScope(), but missed the stream.push(null) call that triggers the 'end' event. When END_STREAM arrives on a trailing HEADERS frame (as gRPC does), the 'end' event fires in the session's async context instead of the request's context. Wrap stream.push(null) at end-of-stream in reqAsync.runInAsyncScope() so that the 'end' event preserves the correct AsyncLocalStorage context. Refs: nodejs#55460 Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
orgads
force-pushed
the
http2-async-trailers
branch
from
August 1, 2026 18:39
a39d251 to
559fba0
Compare
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/74093/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30714978721 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63814 +/- ##
=======================================
Coverage 90.28% 90.29%
=======================================
Files 760 760
Lines 247061 247065 +4
Branches 46592 46587 -5
=======================================
+ Hits 223058 223080 +22
+ Misses 15491 15444 -47
- Partials 8512 8541 +29
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix (f67e45e) wrapped header/response event dispatch in
reqAsync.runInAsyncScope(), but missed thestream.push(null)call that triggers the'end'event. WhenEND_STREAMarrives on a trailingHEADERSframe (as gRPC does), the'end'event fires in the session's async context instead of the request's context.Wrap the
stream.push(null)at end-of-stream inreqAsync.runInAsyncScope()so that the'end'event preserves the correct AsyncLocalStorage context.Refs: