byte_pattern: share the TwoWaySearcher between byte and str - #135931
Open
folkertdev wants to merge 1 commit into
Open
byte_pattern: share the TwoWaySearcher between byte and str #135931folkertdev wants to merge 1 commit into
byte_pattern: share the TwoWaySearcher between byte and str #135931folkertdev wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #134149
An attempt to break up #134350 into more manageable pieces.
From what I can see, the
TwoWaySearcherimplementation does not have special logic for UTF8 boundaries, so it should work just as well on any&[u8]. So this PR just moves theTwoWaySearcherimplementation toslice/byte_pattern.rs, and then uses it fromstr/pattern.rs. No functional changes, no additional API surface.r? @BurntSushi