avoid spurious lifetime diagnostic in async generic case - #158153
Open
pbkx wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-author
pbkx
marked this pull request as ready for review
June 19, 2026 21:56
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? types |
rustbot
added
the
T-types
jackh726
reviewed
Aug 4, 2026
Comment on lines
+623
to
+633
| let static_scc = self.constraint_sccs.scc(self.universal_regions().fr_static); | ||
| let static_bound_errors: FxIndexSet<_> = failed_type_tests | ||
| .iter() | ||
| .filter_map(|&(erased_generic_kind, type_test)| { | ||
| if self.constraint_sccs.scc(type_test.lower_bound) == static_scc { | ||
| Some((erased_generic_kind, type_test.span)) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .collect(); |
Member
There was a problem hiding this comment.
This (entire addition) deserves a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115376.
Issue #115376 reports duplicate lifetime diagnostics for a small async generic example where rustc already emits the real
T: 'staticerror. Additionally, it emits diagnostics requiring the same generic type to outlive a shorter anonymous lifetimeMy PR keeps the real static-bound diagnostic and filters same-span weaker type-test diagnostics for the same generic when the failed
G: 'staticbound already covers them. New regression test verifies that the async example emits only the real E0310 diagnostic. One existing borrowck test was updated for the same diagnostic cleanup