Skip to content

Replace CrateDump with the Debug impl from CStore - #158695

Open
blyxyas wants to merge 1 commit into
rust-lang:mainfrom
blyxyas:remove-cratedump
Open

Replace CrateDump with the Debug impl from CStore#158695
blyxyas wants to merge 1 commit into
rust-lang:mainfrom
blyxyas:remove-cratedump

Conversation

@blyxyas

@blyxyas blyxyas commented Jul 2, 2026

Copy link
Copy Markdown
Member

Redundant struct with only one usecase in a single place while keeping the actual implementation of Debug in CStore empty.

Every line that's removed from the compiler is a win.

Redundant struct with only one usecase in a single place while keeping
the actual implementation of `Debug` in `CStore` empty.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2026
@rustbot

rustbot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants