[WIP] Polymorphization - #160300
Draft
camelid wants to merge 17 commits into
Draft
Conversation
core seems to build successfully now, but miniz_oxide ICEs due to ty_and_layout_field.
Params are local to the function that defines them, but ty::Erased was leaking since called functions and shims may be monomorphized with it as an argument. Will need a more principled approach that allows tracking parameter identity so we can do the sidecar/vtable rewrite for calls that passes type_id, drop, trait methods, etc. However, std successfully builds now and can be linked against from a simple test case that runs! Also had to move an instance.polymorphize() call earlier in symbol mangling to avoid discrepancy. Obviously need a new approach that avoids this ad hoc ness.
randomization_seed prevents polymorphizing instances for types with the same layout but different origins (e.g. two different structs).
rustbot
added
A-LLVM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.