[WIP] suggest parsing string into numeric type on invalid cast

[Snxhit]

fixes #159494

changes:
suggest parsing on invalid string-to-number casts, add ui test for the same.

wip:
suggest parsing on assignment target type mismatch, value checking before suggestion, final ui test.

[rust-log-analyzer]

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#14 2.884 Building wheels for collected packages: reuse
#14 2.885   Building wheel for reuse (pyproject.toml): started
#14 3.100   Building wheel for reuse (pyproject.toml): finished with status 'done'
#14 3.102   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132857 sha256=6a78a69541e3df9c7c106367722bab90241125ee6b7cdb81c5e40637268f85a9
#14 3.102   Stored in directory: /tmp/pip-ephem-wheel-cache-5j_2jg7p/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#14 3.104 Successfully built reuse
#14 3.105 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#14 3.507 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#14 3.507 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#14 4.043 Collecting virtualenv
---
                         err.multipart_suggestion(
                             "consider parsing the string into a numeric type instead",
-                            vec![
-                                (
-                                    self.expr_span.shrink_to_hi().to(self.cast_span),
-                                    format!(".parse::<{target_ty_str}>().unwrap_or_default()"),
-                                ),
-                            ],
+                            vec![(
+                                self.expr_span.shrink_to_hi().to(self.cast_span),
+                                format!(".parse::<{target_ty_str}>().unwrap_or_default()"),
+                            )],
                             rustc_errors::Applicability::MaybeIncorrect,
                         );
                     }
Diff in /checkout/compiler/rustc_hir_typeck/src/cast.rs:608:
                     if let Some(note) = note {
                         err.note(note);
                     }
-                    
+
                     if self.cast_ty.is_numeric() {
                         let expr_ty = fcx.resolve_vars_if_possible(self.expr_ty);
 
Diff in /checkout/compiler/rustc_hir_typeck/src/cast.rs:621:
 
                             err.multipart_suggestion(
                                 "consider parsing the string into a numeric type instead",
-                                vec![
-                                    (
-                                        self.expr_span.shrink_to_hi().to(self.cast_span),
-                                        format!(".parse::<{target_ty_str}>().unwrap_or_default()")
-                                    ),
-                                ],
+                                vec![(
+                                    self.expr_span.shrink_to_hi().to(self.cast_span),
+                                    format!(".parse::<{target_ty_str}>().unwrap_or_default()"),
+                                )],
                                 rustc_errors::Applicability::MaybeIncorrect,
                             );
                         }
fmt: checked 7077 files
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`