Skip to content

diagnostics: reject sanitizer compiles of proc-macro - #160585

Open
durin42 wants to merge 1 commit into
rust-lang:mainfrom
durin42:rustc-reject-sanitizer-proc-macro
Open

diagnostics: reject sanitizer compiles of proc-macro#160585
durin42 wants to merge 1 commit into
rust-lang:mainfrom
durin42:rustc-reject-sanitizer-proc-macro

Conversation

@durin42

@durin42 durin42 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

We discussed this at the project all hands way back in May, and I'm only just now getting to it. Since proc-macros get loaded into rustc, it's not helpful to try and compile them in a sanitizer mode because you'll most likely end up with incompatible uses of things like the sanitizer runtimes.

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

I used an LLM to figure out where to plug this logic in, but I either hand-wrote or scrutinized every line before even committing it, and then self-reviewed again in the web UI before submitting the pull request.

We discussed this at the project all hands way back in May, and I'm only
just now getting to it. Since proc-macros get loaded into rustc, it's
not helpful to try and compile them in a sanitizer mode because you'll
most likely end up with incompatible uses of things like the sanitizer
runtimes.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2026
@rustbot

rustbot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants