Merge compiletest directives to do with llvm versions - #160637
Merge compiletest directives to do with llvm versions#160637WaffleLapkin wants to merge 5 commits into
Conversation
|
Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred in coverage tests. cc @Zalathar
|
rustbot
added
A-compiletest
|
|
rustbot
added
F-explicit_tail_calls
| assert_eq!(extract_llvm_version("9.0.1-rust-1.43.0-dev"), Version::new(9, 0, 1)); | ||
| assert_eq!(extract_llvm_version("9.3.1-rust-1.43.0-dev"), Version::new(9, 3, 1)); | ||
| assert_eq!(extract_llvm_version("10.0.0-rust"), Version::new(10, 0, 0)); | ||
| // assert_eq!(extract_llvm_version("4.5.6git"), Version::new(4, 5, 6)); |
There was a problem hiding this comment.
Is this an actual version string that llvm outputs? In that case I'll have to (partially?) revert the change to extract_llvm_version...
There was a problem hiding this comment.
I don't think so, this was probably just trying to hedge against trailing random things
This comment has been minimized.
This comment has been minimized.
Instead of having separate directives for major versions and whatnot, just use the semver version requirement.
…vm-version` If we don't want them to combine we should explicitly disallow them...
cfd0ca7 to
968a931
Compare
4 participants
I got confused by
min-llvm-versionandmax-llvm-major-versionbeing different not only inmin/max(-major).... So I decided to refactor everything to just use semver version requirements (
//@ llvm-version: <=22, etc). IMO this is much nicer.r? @jieyouxu