Suggest add async for function sig with return expr in body - #160663
Open
chenyukang wants to merge 1 commit into
Open
Suggest add async for function sig with return expr in body#160663chenyukang wants to merge 1 commit into
chenyukang wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
chenyukang
force-pushed
the
yukang-fix-159495-suggest-async-return-future
branch
from
August 7, 2026 01:24
1ba96e4 to
d7a0654
Compare
chenyukang
force-pushed
the
yukang-fix-159495-suggest-async-return-future
branch
from
August 7, 2026 01:38
d7a0654 to
aed866a
Compare
estebank
reviewed
Aug 8, 2026
| error[E0308]: mismatched types | ||
| --> $DIR/suggest-async-fn-for-returned-future-ineligible-issue-159495.rs:12:20 | ||
| | | ||
| LL | let _: i32 = { number() }; |
Contributor
There was a problem hiding this comment.
I wonder if having a help saying "if the function was async, you could await" would make sense for some subset of cases that we are less certain of.
estebank
approved these changes
Aug 8, 2026
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159495
r? @estebank