bootstrap: Remove PATH_REMAP from command-line selector handling - #160675
Open
Zalathar wants to merge 3 commits into
Open
bootstrap: Remove PATH_REMAP from command-line selector handling #160675Zalathar wants to merge 3 commits into
PATH_REMAP from command-line selector handling #160675Zalathar wants to merge 3 commits into
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-bootstrap
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
When registering selector paths/aliases, steps shouldn't need to know their kind.
Remapping of "rust-analyzer-proc-macro-srv" can be avoided by registering it as an alias attached to the real path. Remapping of "test" is not necessary at all, since `./x test tests` naturally selects all of the test suites in `tests`.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remapping of "rust-analyzer-proc-macro-srv" can be avoided by registering it as an alias attached to the real path.
Remapping of "test" is not necessary at all, since
./x test testsnaturally selects all of the test suites intests.(This changes the order of steps listed in the relevant snapshot tests, but the set of steps is unchanged.)
The removal of
ShouldRun::kindis not essential to this PR, but I included it because it would have conflicted with changes to ShouldRun's alias-related methods.