Skip to content

rustc_public: split defs out of ty - #160676

Open
makai410 wants to merge 1 commit into
rust-lang:mainfrom
makai410:rpub/cleanup
Open

rustc_public: split defs out of ty#160676
makai410 wants to merge 1 commit into
rust-lang:mainfrom
makai410:rpub/cleanup

Conversation

@makai410

@makai410 makai410 commented Aug 7, 2026

Copy link
Copy Markdown
Member

This is more of an "I feel like this should be like this" kind of change. I suppose that we might need to make the ty a bit more fine-grained as the coverage expands. That said, I don't have a strong opinion on whether it's necessary, so feel free to close this PR if you find it not convincing enough.

The diff looks so scary, though... I just split ty.rs into def.rs and tys.rs and changed crate_def! and crate_def_with_ty!.

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

@rustbot

rustbot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 7, 2026
@rustbot

rustbot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: project-rustc-public
  • project-rustc-public expanded to celinval, makai410, oli-obk, scottmcm
  • Random selection from celinval, oli-obk, scottmcm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants