autodiff: Normalize typetree struct field types - #160701
Open
Dnreikronos wants to merge 2 commits into
Open
Conversation
FieldDef::ty returns Unnormalized, so skipping normalization left anon-const array lengths unevaluated. That ICEd in struct_tail_for_codegen and emptied TypeTrees for plain [T; N] fields. Normalize with TypingEnv::fully_monomorphized before recursing.
Cover both the ICE path through *mut [T; N] struct fields and the silent empty-TypeTree case for plain [T; N] fields.
rustbot
added
A-run-make
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160635
-Zautodiff=Enablewas ICEing on structs with fields like*mut [f32; N].FieldDef::tyreturnsUnnormalized, and we were just callingskip_norm_wip, so recursion hitstruct_tail_for_codegenwith an unevaluated anon const length. Same root cause also quietly emptied TypeTrees for plain[T; N]fields, fyi.Now we normalize with
TypingEnv::fully_monomorphizedbefore walking struct fields. Imo that's the right call here: we're already post-mono in codegen, and it lines up with the Unnormalized WIP migration instead of spreading moreskip_norm_wiparound. Btw I added a run-make regression covering both faces of the bug.Idk if Enzyme will still choke on murkier shadow-pointer cases irl, but at least rustc stops panicking. Ltm if the FileCheck strings look too layout-locked for other targets and I can loosen them asap.