Disallow accesses through an Index projection when a sibling ConstantIndex projection has been moved out of - #160780
Open
beepster4096 wants to merge 1 commit into
Open
Conversation
…ons to be overlapping in some cases
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
2 tasks
cjgillot
reviewed
Aug 9, 2026
| mpi: MovePathIndex, | ||
|
|
||
| /// The PlaceElem in the place immediately projecting from the parent move path. | ||
| next_elem: PlaceElem<'tcx>, |
Contributor
There was a problem hiding this comment.
Should this be a ProjectionKind?
cjgillot
reviewed
Aug 9, 2026
| // Subslice and ConstantIndex projections of slices also overlap siblings, | ||
| // but the parent slice will never have a move path | ||
| // Subslice projections of arrays are specifically checked in `check_if_subslice_element_is_moved` | ||
| LookupResult::Parent { mpi, next_elem: PlaceElem::Index(..) } => self |
Contributor
There was a problem hiding this comment.
Could we match exhaustively on next_elem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160525
LookupResultenum returned byMovePathLookup::find:LookupResult::Parent(None)case is now a separate variant,LookupResult::NoneLookupResult::Parenthas an additional field containing the variant immediately following the parent move path.check_if_full_path_is_movednow checks that new field and if it isPlaceElem::Index, it makes sure there are no uninit descendants of the indexed array's move path (which can only beConstantIndexand descendants of those.)move_path_closest_tois removed and inlined intocheck_if_full_path_is_moved.