Only pass -Zincremental-verify-ich for incremental compiles - #2510
Open
xmakro wants to merge 1 commit into
Open
Conversation
xmakro
force-pushed
the
verify-ich-incremental-only
branch
from
July 26, 2026 20:07
05c927f to
e9df0eb
Compare
xmakro
marked this pull request as ready for review
July 26, 2026 20:43
Contributor
|
Seems ok to me, though we'll need to be careful when we update the rustc-perf version used by CI, otherwise the improvement might be attributed to a compiler change. |
Member
|
This shouldn't be needed if rust-lang/rust#159796 lands, right? Let's wait for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For non-incremental compiles the flag has no purpose. It triggers a query key verification sweep that costs ~1.3% of instructions on non-incr full measurements. This is overhead that exists only in the benchmark, not in real builds.