Add toEncoding, and few Aeson instances - #21
Merged
Conversation
phadej
force-pushed
the
aeson-to-encoding
branch
2 times, most recently
from
November 24, 2016 13:57
ddd2ca1 to
ab3f935
Compare
phadej
force-pushed
the
aeson-to-encoding
branch
from
November 24, 2016 14:19
ab3f935 to
869dc0d
Compare
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't touch the instance in
ElasticSearch.hs. It's a bit tricky withaeson-0.11, much easier with1.0. OTOH, if @23Skidoo is working on #14, maybe it's easier to do after.