Add flag to force XDP umem hugepage allocation - #2145
Merged
Conversation
ollie-etl
changed the title
Contributor
|
This PR needs to be rebased as well. It also looks like you need to run |
ollie-etl
force-pushed
the
hugepage-support
branch
from
March 13, 2024 10:56
6e02787 to
64d3761
Compare
Contributor
Author
|
@camshaft the failing test seems unrelated (flaky test) |
camshaft
reviewed
Mar 13, 2024
|
|
||
| #[derive(Debug)] | ||
| pub enum MmapOptions { | ||
| None, |
Contributor
There was a problem hiding this comment.
Is this option actually needed if the functions take an Option already?
Contributor
Author
There was a problem hiding this comment.
Completely correct. Fixed
camshaft
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Modifies the XDP Umem builder to include a new flag
hugepage, which when set, sets theMAP_HUGETLBflag in the mmap syscall.Umem is required to be backed by a hugepage, but the current allocation method doesn't guaranteed that, it relies on kernel transparent huge-pages, and if none is available, silently falls back to a none hugepage allocation. This new flag forces hugepage allocation, and will fail if none is avilable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.