test: generate script for testing certs and keys - #2161
Merged
Conversation
toidiu
marked this pull request as ready for review
March 23, 2024 01:02
toidiu
enabled auto-merge (squash)
March 23, 2024 01:02
camshaft
reviewed
Mar 23, 2024
|
|
||
| [ ca_distinguished_name ] | ||
| # country name | ||
| C = JP |
Contributor
There was a problem hiding this comment.
Why these values and not just Seattle?
Contributor
Author
There was a problem hiding this comment.
I borrowed from existing cnf file in the project: https://github.com/aws/s2n-quic/blob/main/examples/s2n-mtls/certs/config/ca.cnf
camshaft
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Certs/Keys used for testing were generated a long time ago and we dont have a way to renew them. Ideally, we can generate new ones when the old ones expire.. and now we can! As it turns out, its non-obvious and it took me awhile to figure out to generate valid cert/key pairs.
Testing:
Existing test should pass. I added a new test for the pkcs#1 encoded cert/key.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.