feat(s2n-quic-dc): add mpsc channel - #2503
Merged
Merged
Conversation
camshaft
force-pushed
the
camshaft/dc-sync-mpsc
branch
from
February 28, 2025 20:31
513bbba to
eb83091
Compare
camshaft
marked this pull request as ready for review
February 28, 2025 20:33
Mark-Simulacrum
approved these changes
Mar 4, 2025
| arrayvec = "0.7" | ||
| atomic-waker = "1" | ||
| aws-lc-rs = "1" | ||
| bach = "0.0.10" |
Collaborator
There was a problem hiding this comment.
dev-dependency? I don't see any usage outside of testing... although maybe testing is public?
Contributor
Author
There was a problem hiding this comment.
yep, you're absolutely right. I will fix that in a follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current
s2n_quic_dc::synconly exports a singlempmcchannel. This change refactors the channel implementation to provide both ampmcandmpscchannel for use cases where there will only be one receiver. This implementation can be a bit cheaper since it uses the existingMutexaround thering_dequeto store the receiver waker.Testing:
I added some high level tests showing that both channel implementations are working as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.