Skip to content

jsrt: Add JavascriptSymbol support to JsObject Get/Has/Set etc.. - #4209

Merged
chakrabot merged 3 commits into
chakra-core:masterfrom
obastemur:support_symbol
Nov 14, 2017
Merged

jsrt: Add JavascriptSymbol support to JsObject Get/Has/Set etc..#4209
chakrabot merged 3 commits into
chakra-core:masterfrom
obastemur:support_symbol

Conversation

@obastemur

Copy link
Copy Markdown
Collaborator

Also;

  • native-tests: automated static test folder discovery
  • native-test: JsObject Get/Has/Set etc. symbol support testing

@boingoing boingoing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obastemur

Copy link
Copy Markdown
Collaborator Author

@boingoing Thanks for the review

@chakrabot
chakrabot merged commit 27ada66 into chakra-core:master Nov 14, 2017
chakrabot pushed a commit that referenced this pull request Nov 14, 2017
…ct Get/Has/Set etc..

Merge pull request #4209 from obastemur:support_symbol

Also;

 - native-tests: automated static test folder discovery
 - native-test: JsObject Get/Has/Set etc. symbol support testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants