Add Fragment Refs to Fabric with intersection observer support - #33056
Merged
Conversation
jackpope
force-pushed
the
fragment-ref-observers-rn
branch
from
April 29, 2025 18:59
6ec93d7 to
d63319b
Compare
rubennorte
approved these changes
Apr 30, 2025
rubennorte
left a comment
rubennorte
left a comment
Member
There was a problem hiding this comment.
Looks good but please make sure we have E2E tests for this in React Native with Fantom when we sync the reconciler.
|
Comparing: 88b9767...a03db6e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Adds Fragment Ref support to RN through the Fabric config, starting with `observeUsing`/`unobserveUsing`. This is mostly a copy from the implementation on DOM, and some of it can likely be shared in the future but keeping it separate for now and we can refactor as we add more features. Added a basic test with Fabric, but testing specific methods requires so much mocking that it doesn't seem valuable here. I built Fabric and ran on the Catalyst app internally to test with intersection observers end to end. DiffTrain build for [408d055](408d055)
This was referenced May 5, 2025
This was referenced May 12, 2025
This was referenced May 19, 2025
This was referenced May 21, 2025
17 tasks
ayan-de
pushed a commit
to ayan-de/react
that referenced
this pull request
Aug 26, 2026
ayan-de
pushed a commit
to ayan-de/react
that referenced
this pull request
Aug 26, 2026
ayan-de
pushed a commit
to ayan-de/react
that referenced
this pull request
Sep 11, 2026
ayan-de
pushed a commit
to ayan-de/react
that referenced
this pull request
Sep 11, 2026
ayan-de
pushed a commit
to ayan-de/react
that referenced
this pull request
Sep 12, 2026
ayan-de
pushed a commit
to ayan-de/react
that referenced
this pull request
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Fragment Ref support to RN through the Fabric config, starting with
observeUsing/unobserveUsing. This is mostly a copy from the implementation on DOM, and some of it can likely be shared in the future but keeping it separate for now and we can refactor as we add more features.Added a basic test with Fabric, but testing specific methods requires so much mocking that it doesn't seem valuable here.
I built Fabric and ran on the Catalyst app internally to test with intersection observers end to end.