[Fast Refresh] Derive the fiber tag from the resolved type when mounting - #36963
Merged
Conversation
github-actions
Bot
added
the
React Core Team
sophiebits
marked this pull request as ready for review
July 8, 2026 07:20
gaearon
approved these changes
Jul 8, 2026
If an edit changed the kind of the type (e.g. a plain function got wrapped in memo()), the fiber could get the old kind's tag with the new kind's type, usually throwing an error.
sophiebits
force-pushed
the
fresh-type-changes/derive-fiber-tag
branch
from
July 8, 2026 16:11
1dd8f42 to
2922920
Compare
Contributor
Author
|
sorry, apparently I need stamps one at a time as the stack rebases |
|
Comparing: df4bd1b...2922920 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
hoxyq
approved these changes
Jul 8, 2026
hoxyq
left a comment
hoxyq
left a comment
Collaborator
There was a problem hiding this comment.
If only landing the whole stack worked! This is such a bad experience, even for an experimental feature.
I had the same issues previously, stamping without a review based on Dan's approval above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an edit changed the kind of the type (e.g. a plain function got
wrapped in memo()), the fiber could get the old kind's tag with the
new kind's type, usually throwing an error.