Conversation
Since the tests only crash on v12.x, this commit adds separate regression tests. Refs: nodejs#15102
nodejs-github-bot
added
the
test
addaleax
added
http
3 tasks
commented
Jul 7, 2020
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32245/ (:green_heart:) |
18 tasks
commented
Jul 8, 2020
Member
lpinca
approved these changes
Jul 8, 2020
This was referenced Jul 9, 2020
commented
Jul 14, 2020
Member
Author
|
Landed in 18667ac |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the tests only crash on v12.x, this commit adds separate
regression tests.
Refs: #15102
Refs: #34016
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes