src,node-api: fatal errors should not assume a current isolate may exist - #38624
Closed
legendecas wants to merge 1 commit into
Closed
legendecas wants to merge 1 commit into
legendecas wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
legendecas
force-pushed
the
node-api/fatal-error
branch
from
May 11, 2021 17:32
68f4651 to
0b3883d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/38033/
|
Member
|
The CI failure appears to be relevant to this change (that is, it's not just a flaky failure) |
Member
Author
|
@jasnell which one do you refer to? I checked out https://ci.nodejs.org/job/node-test-pull-request/38033/ and found out the failing case is "parallel/test-domain-error-types" which doesn't seem to be related to this change. |
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/38036/
|
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/38054/
|
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/38060/
|
Member
Author
|
The linux one case is also failing on PRs like: #38665 (comment) |
mhdawson
reviewed
May 14, 2021
Member
There was a problem hiding this comment.
Suggested change
| ABORT(); | |
| fflush(stderr); | |
| ABORT(); |
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/38126/ Linux One:
|
napi_fatal_error and node watchdog trigger fatal error but rather running on a thread that hold no current isolate.
legendecas
force-pushed
the
node-api/fatal-error
branch
from
May 16, 2021 09:15
fc0390c to
57d024a
Compare
commented
May 16, 2021
Collaborator
commented
May 18, 2021
Member
Author
|
Landed in f536cc2 |
This was referenced Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segment fault on
Environment::GetCurrent(isolate)on fatal error.napi_fatal_error and node watchdog triggers fatal error but rather
running on a thread that holds no current isolate.