fix(parser): emit targeted diagnostic for fields inside traits - #162103
Open
raushan728 wants to merge 2 commits into
Open
fix(parser): emit targeted diagnostic for fields inside traits#162103raushan728 wants to merge 2 commits into
raushan728 wants to merge 2 commits into
Conversation
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
davidtwco
reviewed
Sep 4, 2026
| fn main() {} | ||
|
|
||
| trait Trait1 { | ||
| field_name: String, //~ ERROR fields are not allowed in trait definitions |
Member
There was a problem hiding this comment.
Can you add tests for cases without a trailing comma?
Contributor
Author
There was a problem hiding this comment.
Hi @davidtwco please take a second look.
Detect `ident: Type` or `self: Type` inside trait bodies to emit a clearer diagnostics.
raushan728
force-pushed
the
issues/161815
branch
from
September 5, 2026 05:51
9da1213 to
6b9210c
Compare
Contributor
Author
Here it feels like you are telling me to do less testing work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161815
Detect
ident: Typeorself: Typeinside trait bodies to emit a clearer diagnostic.