Better diagnostic for relative paths in visibilities - #162114
Open
bb1yd wants to merge 1 commit into
Open
Conversation
bb1yd
force-pushed
the
better-diag-for-visibility
branch
2 times, most recently
from
September 1, 2026 10:30
917b062 to
db99edf
Compare
This comment has been minimized.
This comment has been minimized.
bb1yd
force-pushed
the
better-diag-for-visibility
branch
from
September 1, 2026 10:57
db99edf to
753af44
Compare
bb1yd
marked this pull request as ready for review
September 1, 2026 14:50
Collaborator
|
Some changes occurred in diagnostic error codes |
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118878
Note that the compiler suggest
pub(in super)instead ofpub(super), because we can only get the span of the path.in superis valid but tell me if there are better ways to do this :)I also change the original message from
trytotry adding a `crate` prefixbecause rustc stops inlining the suggestion when there are multiple, and a single word looks weird: