Skip to content

Add regression tests for issues marked fixed-by-next-solver (1/N) - #162137

Open
Randl wants to merge 1 commit into
rust-lang:mainfrom
Randl:test-fixed-issues-1
Open

Add regression tests for issues marked fixed-by-next-solver (1/N)#162137
Randl wants to merge 1 commit into
rust-lang:mainfrom
Randl:test-fixed-issues-1

Conversation

@Randl

@Randl Randl commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Note that while these issues are marked fixed-by-next-solver, some of them also pass with the old solver now.

Fixes #90950
Fixes #102580
Fixes #134312
Fixes #134370
Fixes #141478

LLM disclosure: I used LLM to collect and classify the issues. After that, I manually extracted the MCE from each issue and checked how it failed on older Rust versions.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2026
@rustbot

rustbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@chenyukang

Copy link
Copy Markdown
Member

Maybe you need to add multiple Fixes #issue_no in PR description to close those issues when PR merged?

@@ -0,0 +1,17 @@
//@ compile-flags: -Znext-solver
//@ check-pass

@chenyukang chenyukang Sep 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same program fails with E0284 on Rust 1.75.0 but passes with the old solver on nightly. Suggest adding current and next revisions preserve both behaviors.

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails for me with E0284 with the old solver, both locally and at godbolt. Could it be that you checked with the (default) new solver?

Comment thread tests/ui/async-await/async-closures/dyn-coercion-asyncfn-issue-160355.rs Outdated
@chenyukang

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026
@rustbot

rustbot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Randl
Randl force-pushed the test-fixed-issues-1 branch from d1dda38 to 87f7eee Compare September 11, 2026 06:05
@rustbot

rustbot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Randl

Randl commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

I've added the fixes comment only to tests that pass with both solvers

@Randl

Randl commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

3 participants