Fix Query Loop block rendering for users without permissions to edit the post type #72500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
[Type] Bug
|
Size Change: +27 B (0%) Total Size: 2.17 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 09a5dcb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18657831305
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is currently a bug that users without permissions to edit a specific product type aren't allowed to see the Query Loop block in the editor if it queries that product type. For example, if an author user edits a post containing the Query Loop block with Pages as the post type, the block only renders an infinite spinner.
Why?
While right now users are not allowed to select post types they don't have permissions to edit in the Query Loop block, other users might modify their posts and add the block. Right now, Gutenberg only renders an infinite scroll which seems broken.
In addition to that, some plugins out there like WooCommerce might use blocks like Post Title for products and make them available to users without permission to edit titles.
How?
This PR:
context: view, so users don't need to have permission to edit that post type to be able to see the Query Loop block preview.context: view, so the correct title is displayed.Testing Instructions
Only Gutenberg:
On WooCommerce: